FEATURE: New and Unread messages for user personal messages. #13603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
unread_new_messages
branch
7 times, most recently
from
4933128
to
a5dd25d
Compare
|
This pull request introduces 1 alert when merging a5dd25d4e09fc87d579decf04a94624b858741ac into 87c1e98 - view on LGTM.com new alerts:
|
tgxworld
force-pushed
the
unread_new_messages
branch
22 times, most recently
from
d3dfe7a
to
01aef27
Compare
tgxworld
force-pushed
the
unread_new_messages
branch
22 times, most recently
from
84da8a9
to
96fd45a
Compare
Too much effort to properly implement a tag filter now. Plus that is not our priority.
tgxworld
force-pushed
the
unread_new_messages
branch
from
96fd45a
to
34e199d
Compare
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/new-all-pms-feature-timing-out/203002/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the "Unread" and "New" filter when viewing personal messages. However, the additional of the two new filters means that we have to revamp the UI of personal messages so that we do not display a ton of options in the navigation links. In the UI revamp, we allow messages to be filtered by the different inboxes as well as tags.
Screenshots
Desktop with inboxes filter
Desktop without inboxes filter
Mobile with inboxes filter
Mobile without inboxes filter
Group Inbox
Things that have been left out intentionally in this PR